search

UsergeTeam / Userge

Userge, Durable as a Serge
https://userge.tech
GNU General Public License v3.0
676 stars 2.02k forks source link

Updated details and text of all plugins 😋 #417

Closed Navaneeth-Renjith closed 2 years ago

Navaneeth-Renjith commented 2 years ago

I've given some changes to details and texts of all plugins in Userge. I've taken 3-4 hours to make this change.

Explanation of some changes

I've changed smiley icons to emojis. Because, messages in Telegram supports emojis, as in inline also. For example, I've changed :) icon to 🙂 emoji. Then, I've made changes to some texts.

Renamed some plugins...

And, there is another changes also. You can check it at the Commits tab.

I'm hoping...

I'm hoping that you'll push this because, I've worked for 3-4 hours for this change.

Note:

pep8speaks commented 2 years ago

@NavaneethRenjith8282, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-12-14 13:19:52 UTC
Navaneeth-Renjith commented 2 years ago

@NavaneethRenjith8282, Thanks for updating this PR.

Line 47:76: W291 trailing whitespace

Comment last updated at 2021-12-12 06:49:23 UTC

Lint Errors fixed due to recommendation of @Krishna-Singhal . View message here...

Krishna-Singhal commented 2 years ago

@NavaneethRenjith8282, Thanks for updating this PR.

Line 47:76: W291 trailing whitespace

Comment last updated at 2021-12-12 06:49:23 UTC

Lint Errors fixed due to recommendation of @Krishna-Singhal . View message here...

They are still there :(

Navaneeth-Renjith commented 2 years ago

Lint Errors fixed due to recommendation of @Krishna-Singhal . View message here...

They are still there :(

No problem, @Krishna-Singhal. You can still edit this because, I've given it's access “Allow edit access by maintainers”. So, you can edit it and merge it. 🙂

Jigarvarma2005 commented 2 years ago

I've given some changes to details and texts of all plugins in Userge. I've taken 3-4 hours to make this change.

Explanation of some changes

I've changed smiley icons to emojis. Because, messages in Telegram supports emojis, as in inline also. For example, I've changed :) icon to 🙂 emoji. Then, I've made changes to some texts.

Renamed some plugins...

  • I've given a change to voice-call plugin. I've changed it's name to video-chat. Because, Telegram has changed renamed Voice Chat as Video Chat.
  • I've changed gdrive to google_drive. Because, Google Drive, Google are trademarks of Google LLC. And, I don't like to show it as GDrive. That's why I made up this change.

And, there is another changes also. You can check it at the Commits tab.

I'm hoping...

I'm hoping that you'll push this because, I've worked for 3-4 hours for this change.

Note:

  • I've changed only the names and texts of plugins, commands, and it's texts. I didn't changed any other thing.

Try this for weather.py pep8 fix 👇👇 Weather.py

Navaneeth-Renjith commented 2 years ago

Try this for weather.py pep8 fix 👇👇 Weather.py

Thanks for helping me, @Jigarvarma2005! I've changed the commit to the text you've given.

Jigarvarma2005 commented 2 years ago

Try this for weather.py pep8 fix 👇👇 Weather.py

Thanks for helping me, @Jigarvarma2005! I've changed the commit to the text you've given.

fix deepsource too

Navaneeth-Renjith commented 2 years ago

Try this for weather.py pep8 fix 👇👇 Weather.py

Thanks for helping me, @Jigarvarma2005! I've changed the commit to the text you've given.

fix deepsource too

I want to consider creating decoration with @staticmethod because, DeepSource says to do it for perfomance improvements. 😕 It wants to be in this line:

  async def paste(self, ses: aiohttp.ClientSession,

Should I want to do this?

Jigarvarma2005 commented 2 years ago

Try this for weather.py pep8 fix 👇👇 Weather.py

Thanks for helping me, @Jigarvarma2005! I've changed the commit to the text you've given.

fix deepsource too

I want to consider creating decoration with @staticmethod because, DeepSource says to do it for perfomance improvements. 😕 It wants to be in this line:

  async def paste(self, ses: aiohttp.ClientSession,

Should I want to do this?

try this for deepsource

rss_feed.py

Jigarvarma2005 commented 2 years ago

lol

Harsh-br0 commented 2 years ago

He can just practice GitHub with this PR ig , already messed with code

Jigarvarma2005 commented 2 years ago

He can just practice GitHub with this PR ig , already messed with code

yeah

Navaneeth-Renjith commented 2 years ago

Sorry...

I don't know why this issue need this much problems. Someone says in comment:

@Harsh-br0 :

He can just practice GitHub with this PR ig , already messed with code

Yes. I can also do it. But, there is still many problems in this pull request. So, maybe I think to close this pull request. Don't worry, I won't close this now. Please wait until I get any ideas...

Harsh-br0 commented 2 years ago

I don't know why this issue need this much problems

Not your fault too but you should control your curiosity like first get the knowledge before doing it and be eligible to go for it

rking32 commented 2 years ago

@NavaneethRenjith8282 Sorry to say this. Apparently, you have messed up the code.

Navaneeth-Renjith commented 2 years ago

@NavaneethRenjith8282 Sorry to say this. Apparently, you have messed up the code.

Sorry everyone. I'm closing now.

Navaneeth-Renjith commented 2 years ago

Sorry...

I don't know why this issue need this much problems. Someone says in comment:

@Harsh-br0 :

He can just practice GitHub with this PR ig , already messed with code

Yes. I can also do it. But, there is still many problems in this pull request. So, maybe I think to close this pull request. Don't worry, I won't close this now. Please wait until I get any ideas...

So, closing this issue now. Thanks for helping me!!! ❤️❤️❤️