search

UsergeTeam / Userge

Userge, Durable as a Serge
https://userge.tech
GNU General Public License v3.0
676 stars 2.02k forks source link

fix for incoming handlers for reaction #449

Closed Krishna-Singhal closed 2 years ago

rking32 commented 2 years ago

did you test this? m.reactions always null for me

Krishna-Singhal commented 2 years ago

did you test this? m.reactions always null for me

i tested, it's None when message doesn't contains reactions other return List of reactions

rking32 commented 2 years ago

Let's say,

a sudo user sends the !ping command > triggers (m.reactions is None) then he reacts to that message > doesn't trigger (m.reactions not None) removes the reaction > triggers (m.reactions is None)

so how do handle the last case? shouldn't trigger r8?

subinps commented 2 years ago

Let's say,

a sudo user sends the !ping command > triggers (m.reactions is None) then he reacts to that message > doesn't trigger (m.reactions not None) removes the reaction > triggers (m.reactions is None)

so how do handle the last case? shouldn't trigger r8?

Edited update is received only once. Example: When the user sends command for first time, reactions are none, if once reacted it contains the reactions (only this time edited handler triggers) later if he removes the reactions again reactions are none but it won't trigger the command since no edited update will be received.

Krishna-Singhal commented 2 years ago

closing because of conflicts and no valid solution yet to handle that