UsergeTeam / Userge

Userge, Durable as a Serge
https://userge.tech
GNU General Public License v3.0
676 stars 2.02k forks source link

upload: audio_upload: replace space between name and size in caption with newline #456

Closed yshalsager closed 2 years ago

yshalsager commented 2 years ago

This way caption in RTL languages on files can be shown correctly.

Before: image

After: image

Krishna-Singhal commented 2 years ago

This way caption in RTL languages on files can be shown correctly.

Before: image

After: image

Bruh I think before one is better than after

yshalsager commented 2 years ago

Bruh I think before one is better than after

It's not about better or worse, the whole point is to make it compatible with RTL captions, which isn't displayed correctly at the moment.

Harsh-br0 commented 2 years ago

Seems this guy started a game like thing to compete for more activity among other contributors

yshalsager commented 2 years ago

@Harsh-br0 lol no, I am just purposing changes for stuff I encounter while using the bot daily. If you don't like external contributions it's fine.

Krishna-Singhal commented 2 years ago

It's not about better or worse, the whole point is to make it compatible with RTL captions, which isn't displayed correctly at the moment.

What about this

before image

after image

isn't filename looks ugly in RTL language ?

Harsh-br0 commented 2 years ago

@Harsh-br0 lol no, I am just purposing changes for stuff I encounter while using the bot daily. ~If you don't like external contributions it's fine.~

Chill bro , am not serious about that just mocking around ¯\_(ツ)_/¯

yshalsager commented 2 years ago

It's not about better or worse, the whole point is to make it compatible with RTL captions, which isn't displayed correctly at the moment.

What about this

before image

after image

isn't filename looks ugly in RTL language ?

So? :D It's about displaying it properly from right to left, because as you can see in the first screenshot file size interferes with the name causing it to be shown incorrectly (file size first then rest of file name).

Krishna-Singhal commented 2 years ago

So? :D It's about displaying it properly from right to left, because as you can see in the first screenshot file size interferes with the name causing it to be shown incorrectly (file size first then rest of file name).

its fine if file name is first then file size.

yshalsager commented 2 years ago

So? :D It's about displaying it properly from right to left, because as you can see in the first screenshot file size interferes with the name causing it to be shown incorrectly (file size first then rest of file name).

its fine if file name is first then file size.

How can it be fine? The current implementation is f"{path.name} [ {file_size} ] already, and filename is not shown correctly as I demonstrated.

Krishna-Singhal commented 2 years ago

How can it be fine? The current implementation is f"{path.name} [ {file_size} ] already, and filename is not shown correctly as I demonstrated.

but with this implementation, it's not good in LTR languages and majority of LTR languages is greater than RTL

yshalsager commented 2 years ago

How can it be fine? The current implementation is f"{path.name} [ {file_size} ] already, and filename is not shown correctly as I demonstrated.

but with this implementation, it's not good in LTR languages and majority of LTR languages is greater than RTL

How could it be not good with LTR? I can't understand how a single new line can be this bad.

rking32 commented 2 years ago

Let's merge this if actually matters to RTL users.

yshalsager commented 2 years ago

@rking32 Much appreciated