Closed yshalsager closed 2 years ago
This way caption in RTL languages on files can be shown correctly.
Before:
After:
Bruh I think before one is better than after
Bruh I think before one is better than after
It's not about better or worse, the whole point is to make it compatible with RTL captions, which isn't displayed correctly at the moment.
Seems this guy started a game like thing to compete for more activity among other contributors
@Harsh-br0 lol no, I am just purposing changes for stuff I encounter while using the bot daily. If you don't like external contributions it's fine.
It's not about better or worse, the whole point is to make it compatible with RTL captions, which isn't displayed correctly at the moment.
What about this
before
after
isn't filename looks ugly in RTL language ?
@Harsh-br0 lol no, I am just purposing changes for stuff I encounter while using the bot daily. ~If you don't like external contributions it's fine.~
Chill bro , am not serious about that just mocking around ¯\_(ツ)_/¯
It's not about better or worse, the whole point is to make it compatible with RTL captions, which isn't displayed correctly at the moment.
What about this
before
after
isn't filename looks ugly in RTL language ?
So? :D It's about displaying it properly from right to left, because as you can see in the first screenshot file size interferes with the name causing it to be shown incorrectly (file size first then rest of file name).
So? :D It's about displaying it properly from right to left, because as you can see in the first screenshot file size interferes with the name causing it to be shown incorrectly (file size first then rest of file name).
its fine if file name is first then file size.
So? :D It's about displaying it properly from right to left, because as you can see in the first screenshot file size interferes with the name causing it to be shown incorrectly (file size first then rest of file name).
its fine if file name is first then file size.
How can it be fine? The current implementation is f"{path.name} [ {file_size} ]
already, and filename is not shown correctly as I demonstrated.
How can it be fine? The current implementation is
f"{path.name} [ {file_size} ]
already, and filename is not shown correctly as I demonstrated.
but with this implementation, it's not good in LTR languages and majority of LTR languages is greater than RTL
How can it be fine? The current implementation is
f"{path.name} [ {file_size} ]
already, and filename is not shown correctly as I demonstrated.but with this implementation, it's not good in LTR languages and majority of LTR languages is greater than RTL
How could it be not good with LTR? I can't understand how a single new line can be this bad.
Let's merge this if actually matters to RTL users.
@rking32 Much appreciated
This way caption in RTL languages on files can be shown correctly.
Before:
After: