UsernameFodder / pmdsky-debug

Debug info for reverse engineering PMD: Explorers of Sky
GNU General Public License v3.0
38 stars 20 forks source link

Improve dev experience around header compiler errors #193

Closed UsernameFodder closed 1 year ago

UsernameFodder commented 1 year ago

Since introducing versioned headers, the header make targets were compiling the base pmdsky.h at the same time as the versioned variants. This means that if a version-agnostic error is introduced, building a make target would essentially print the same error 4 times, one for each header variant. This is annoying, especially since the vast majority of errors aren't going to be version-specific.

Now, compile the base pmdsky.h first, and only move onto the versioned headers if pmdsky.h is valid. This way, most errors will only be printed once.

Also suppress -Wincompatible-library-redeclaration in the automated workflows (caused by redefined builtins); these are unnecessarily noisy and aren't useful.