UsernameFodder / pmdsky-debug

Debug info for reverse engineering PMD: Explorers of Sky
GNU General Public License v3.0
38 stars 20 forks source link

Duplicate addresses for GUMMI_IQ_STRING_IDS and GUMMI_LIKE_STRING_IDS #214

Closed AnonymousRandomPerson closed 11 months ago

AnonymousRandomPerson commented 11 months ago

Describe the bug In overlay 29, GUMMI_IQ_STRING_IDS and GUMMI_LIKE_STRING_IDS both point to NA 0x23532D0, creating a conflict.

To Reproduce Open symbols/overlay29.yml and find GUMMI_IQ_STRING_IDS.

Expected behavior GUMMI_IQ_STRING_IDS should have the correct address and not a duplicate.

Screenshots N/A

Desktop environment N/A

Additional context The actual value within the ROM has a size of 8, which matches GUMMI_LIKE_STRING_IDS. GUMMI_IQ_STRING_IDS has a size of 0xA, so this one likely has a mislabeled address.