search

UsernameFodder / pmdsky-debug

Debug info for reverse engineering PMD: Explorers of Sky
GNU General Public License v3.0
38 stars 20 forks source link

Replace GetSleepAnimationId with GetIdleAnimationId #251

Closed Frostbyte0x70 closed 5 months ago

Frostbyte0x70 commented 5 months ago

Better documents GetSleepAnimationId, which is actually used to get the animation a monster should play while idling. The function has been renamed to GetIdleAnimationId.

Also documents ChangeMonsterAnimation.

UsernameFodder commented 5 months ago

Oh well I guess an alias is okay too. I figured you didn't want to add one since it's not exactly correct, but I don't mind either way.

Frostbyte0x70 commented 5 months ago

I just added the old name as an alias (I forgot the alias system is a thing now), although I don't know if it would be better to remove it, since the old name is incorrect.

UsernameFodder commented 5 months ago

I just added the old name as an alias (I forgot the alias system is a thing now), although I don't know if it would be better to remove it, since the old name is incorrect.

I kind of doubt many people use this symbol? So if I had to choose I might lean towards no alias, but will defer to you.

Frostbyte0x70 commented 5 months ago

Alright, I'll remove it then. I thought it was mandatory to add an alias since the checks were failing.

UsernameFodder commented 5 months ago

Alright, I'll remove it then. I thought it was mandatory to add an alias since the checks were failing.

It'll only fail for the PR the change is introduced in. So it's an ignorable error.