UshakovVasilii / gnome-shell-extension-freon

Shows CPU temperature, disk temperature, video card temperature (NVIDIA/Catalyst/Bumblebee&NVIDIA), voltage and fan RPM
https://extensions.gnome.org/extension/841/freon
GNU General Public License v2.0
424 stars 77 forks source link

Migrate Plugin to Gnome 45 Shell #267

Closed menocheck closed 11 months ago

menocheck commented 11 months ago

Hi, I've started porting the plugin to work with Gnome 45.

The Settings Panel and the Top-bar Indicator function again but I wasn't able to fix the Dropdown Menu. It doesn't open instead I got a bunch of errors:

clutter_actor_set_allocation_internal: assertion '!isnan (box->x1) && !isnan (box->x2) && !isnan (box->y1) && !isnan (box->y2)' failed ../clutter/clutter/clutter-actor.c:8775: Actor '[:0x561403846300]' tried to allocate a size of -2147483648,00 x -2147483648,00 ../clutter/clutter/clutter-actor.c:8775: Actor '[:0x561401d6c7e0]' tried to allocate a size of -2147483648,00 x -2147483648,00 clutter_actor_set_allocation_internal: assertion '!isnan (box->x1) && !isnan (box->x2) && !isnan (box->y1) && !isnan (box->y2)' failed ../clutter/clutter/clutter-actor.c:8775: Actor '[:0x561403846300]' tried to allocate a size of -2147483648,00 x -2147483648,00 ../clutter/clutter/clutter-actor.c:8775: Actor '[:0x561401d6c7e0]' tried to allocate a size of -2147483648,00 x -2147483648,00 clutter_actor_set_allocation_internal: assertion '!isnan (box->x1) && !isnan (box->x2) && !isnan (box->y1) && !isnan (box->y2)' failed ../clutter/clutter/clutter-actor.c:8775: Actor '[:0x561403846300]' tried to allocate a size of -2147483648,00 x -2147483648,00 ../clutter/clutter/clutter-actor.c:8775: Actor '[:0x561401d6c7e0]' tried to allocate a size of -2147483648,00 x -2147483648,00 Can't update stage views actor [:0x561402e89630] is on because it needs an allocation. Can't update stage views actor [:0x561402e89630] is on because it needs an allocation. Can't update stage views actor [:0x561402e89630] is on because it needs an allocation. cogl_framebuffer_set_viewport: assertion 'width > 0 && height > 0' failed

menocheck commented 11 months ago

Managed to fix the error with the dropdown menu. I've updated the commit.

daenney commented 11 months ago

@UshakovVasilii Would you be able to tag a new EGO-xx version? The plugin won't be rebuilt in a bunch of places without the new tag.

UshakovVasilii commented 10 months ago

I create EGO-53 tag, extension under review

https://extensions.gnome.org/extension/841/freon/

UshakovVasilii commented 10 months ago

Review was Rejected:

  1. Don't use imports. in 45 extensions (line 15 freeipmiUtil.js).

  2. getSettings() doesn't exist in 45 (line 17 freeipmiUtil.js). and if you want to use sudo use pkexe instead: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#privileged-subprocess-must-not-be-user-writable

  3. Extensions cannot use run_dispose() (line 112 and 115 udisks2.js):

    This function should only be called from object system implementations.

    https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose

I'm currently use Xfce, so I cannot fix problems.