search

UsmanAhmadSaeed / Animations

Animations is an open source collection of coded animations, containing but not limited to loaders, menus, scroll transitions, and much more.
https://animations.gq
Mozilla Public License 2.0
16 stars 42 forks source link

Login Form Animation #52

Closed Pggeeks closed 1 year ago

Pggeeks commented 1 year ago

#hacktoberfest #hacktoberfest2022

https://user-images.githubusercontent.com/82941619/194822674-c223fd9b-84f2-49e4-9775-44c54074b3a6.mp4

UsmanAhmadSaeed commented 1 year ago

@Pggeeks I'll review and update! If your code doesn't contain comments, make sure to do so.

UsmanAhmadSaeed commented 1 year ago

@Pggeeks comments are not there. Also, in my opinion a slight transition on hover of submit button might be better.

Pggeeks commented 1 year ago

@Pggeeks comments are not there. Also, in my opinion a slight transition on hover of submit button might be better.

Done ✔️ @UsmanAhmadSaeed

UsmanAhmadSaeed commented 1 year ago

@Pggeeks I've checked the PR again and comments are not really helpful. Please read this for a general overview of coding best practices. https://www.thinkful.com/blog/coding-best-practices/

UsmanAhmadSaeed commented 1 year ago

@Pggeeks I've checked the PR again and comments are not really helpful. Please read this for a general overview of coding best practices. https://www.thinkful.com/blog/coding-best-practices/

Pggeeks commented 1 year ago

@UsmanAhmadSaeed Added new & lots of comments. thank you for noting my mistake.