search

UsmanAhmadSaeed / Animations

Animations is an open source collection of coded animations, containing but not limited to loaders, menus, scroll transitions, and much more.
https://animations.gq
Mozilla Public License 2.0
16 stars 42 forks source link

Add: Input Field Animations #53

Closed renzien closed 1 year ago

renzien commented 1 year ago

Hi! @UsmanAhmadSaeed I've been added Input Field Animations. I hope you can review it

UsmanAhmadSaeed commented 1 year ago

@renzien I'll check and update!

renzien commented 1 year ago

Okay! I'll be waiting @UsmanAhmadSaeed because i'm doing it for Hacktoberfest

UsmanAhmadSaeed commented 1 year ago

@renzien I've reviewed your code. Please take a look at contribution guidelines of project, and update your PR accordingly. For example, add comments in your code. Also, the email field seems to be glitching.

renzien commented 1 year ago

@UsmanAhmadSaeed Alright, let me take a look!

renzien commented 1 year ago

Hi! @UsmanAhmadSaeed Sorry for bothering you again. I've already updated the comment on code, and the glitch in email box, is the bouncing animation. Sorry for the mistake. I hope i can be accepted

UsmanAhmadSaeed commented 1 year ago

@renzien thanks for the update. I reviewed again.

  1. Comments are meant to be descriptive and concise so that they clearly explain what the code does and how it does that, i.e. the logic. I believe you can do better.
  2. The glitch is still there. I'm attaching a video for better communication on what I mean

https://user-images.githubusercontent.com/20966983/195383143-19e602d0-2011-407e-94a3-8ddbf5ae1a15.mp4

renzien commented 1 year ago

@UsmanAhmadSaeed Alright! I'll be fix it soon

renzien commented 1 year ago

Hi! @UsmanAhmadSaeed I've been updating the desc comment. And also, i have been fixing the email animations. So, i will put the video, for the result. I hope it can be accepted.

https://user-images.githubusercontent.com/77705313/195392814-85ce6c2f-d1c7-4fa5-aed3-b3a46a664106.mp4

UsmanAhmadSaeed commented 1 year ago

@renzien great work. one last thing. I believe the animations are glitching in Firefox because you haven't added compatibility for these browsers. Please create three instances of properties such as transform and use relevant prefixes image

renzien commented 1 year ago

@UsmanAhmadSaeed Ahh, yess i forgot to input compatibility. Okay, thank you for reminding me. I will fix it soon!