search

UsmanAhmadSaeed / Animations

Animations is an open source collection of coded animations, containing but not limited to loaders, menus, scroll transitions, and much more.
https://animations.gq
Mozilla Public License 2.0
16 stars 42 forks source link

New animation #58

Closed Yash-RajSingh closed 1 year ago

UsmanAhmadSaeed commented 1 year ago

@Yash-RajSingh Please review contribution guidelines and adhere to them, such as properly commenting your code. Opinion: I think the underline could be made more stylish to make it appear like a road or path with walls, or at least just thin the underline.

Yash-RajSingh commented 1 year ago

@Yash-RajSingh Please review contribution guidelines and adhere to them, such as properly commenting your code. Opinion: I think the underline could be made more stylish to make it appear like a road or path with walls, or at least just thin the underline.

Is it okay now?

UsmanAhmadSaeed commented 1 year ago

@Yash-RajSingh There's a gap when balls are inside the circle. Not sure that was intentional. Also, apply coding best practices, such as proper comments etc.

Yash-RajSingh commented 1 year ago

@Yash-RajSingh There's a gap when balls are inside the circle. Not sure that was intentional. Also, apply coding best practices, such as proper comments etc.

The gap was intentional so that it seemed like they were hovering but I've reduced it and I've added proper comments.