search

UsmanAhmadSaeed / Animations

Animations is an open source collection of coded animations, containing but not limited to loaders, menus, scroll transitions, and much more.
https://animations.gq
Mozilla Public License 2.0
16 stars 42 forks source link

please review it. This is the image of changes which i have done in #40. #65

Open anupriyajain595 opened 1 year ago

anupriyajain595 commented 1 year ago

Screenshot (4)

UsmanAhmadSaeed commented 1 year ago

@anupriyajain595 I'll review and update.

anupriyajain595 commented 1 year ago

Okay sir

DevKosov commented 1 year ago

Please read our rules and guidelines before adding an animation.

Our rules specify that the animation has to be from pure HTML, CSS, JS and not any other framework but GSAP.

You're using Typed. It would be a really good JavaScript challenge to remove the framework and try to recreate the same thing.

anupriyajain595 commented 1 year ago

Sir i have removed the framework so please review it.

UsmanAhmadSaeed commented 1 year ago

@anupriyajain595 please add comments and follow coding best practices. Please take a look at all our guidelines before next commit. Also, I've added the hacktoberfest accepted label so don't worry about that.