search

UsmanAhmadSaeed / Animations

Animations is an open source collection of coded animations, containing but not limited to loaders, menus, scroll transitions, and much more.
https://animations.gq
Mozilla Public License 2.0
16 stars 42 forks source link

simple button animation #71

Closed KrunalGupta02 closed 1 year ago

KrunalGupta02 commented 1 year ago

Simple button animation for beginner programmer

KrunalGupta02 commented 1 year ago

Hi maintainer kindly add the hacktoberfest label too

KrunalGupta02 commented 1 year ago

Kindly merge it plz

UsmanAhmadSaeed commented 1 year ago

@KrunalGupta02 kindly take a look at our guidelines and update accordingly. I'm adding the hacktoberfest-accepted label for now, but if there's no update within a week, I'll have to mark it as spam.

KrunalGupta02 commented 1 year ago

@UsmanAhmadSaeed can u pls tell what changes i have to make as i have done within community guidelines if possible

UsmanAhmadSaeed commented 1 year ago

@KrunalGupta02 for instance, you haven't followed coding best practices

KrunalGupta02 commented 1 year ago

Kindly remove the spam as hacktoberfest is ended i don't have time to changes as my exam are coming plz

UsmanAhmadSaeed commented 1 year ago

@KrunalGupta02 there was one week limit, and the changes required were a task of a few minutes in itself, for describing a few lines of code one wrote doesn't take that long. Besides, you could've simply said that you won't be able to do it until after your exams. Hope you understand how this appears. I have switched the labels, but the against guidelines label will stay until PR is updated to match guidelines.