search

UtahDave / salt-vagrant-demo

Demo of Salt in Vagrant. 1 master and 2 minions
Apache License 2.0
247 stars 192 forks source link

Add support for parallels provider if it exists. #16

Closed rterbush closed 8 years ago

UtahDave commented 8 years ago

Hi @rterbush, I'm sorry I've let this PR languish. I've come back to this many times. I think I'm going to close this PR rather than merge it. Basically, my reason is that I want to keep this example as simple as possible. While I really like the idea of having Parallels support in general, I think it will add a bit more complexity to the Vagrantfile than I'd like. Since this is a salt-vagrant-demo I think I'll keep it Vagrant-centric for now and keep things as simple as possible.

Thanks so much for your PR and the time you put into it. I'd be open to having another repo that includes more complicated examples if you think that would be helpful. Let me know what you think.

rterbush commented 8 years ago

Dave,

Just to make a point here, using Parallels instead of Virtualbox for the VM has nothing to do with Vagrant itself. Parallels is just another VM provider for use with Vagrant so I don't think making the Vagrantfile portable to support a common Mac VM software would deviate from the goal of a "vagrant-salt" demo. The changes I made, determine what VM service you have available on the computer you are running on. It uses Parallels if available, otherwise it falls back to Virtualbox. The Vagrantfile does not require any changes or configuration to for use on any operating system with Vagrant installed.

If that really does overcomplicate it for folks, it would at least be worth dropping it in a contrib folder for those of us that prefer to use Parallels.

Randy

On Fri, Jun 10, 2016 at 3:04 PM, David Boucha notifications@github.com wrote:

Hi @rterbush https://github.com/rterbush, I'm sorry I've let this PR languish. I've come back to this many times. I think I'm going to close this PR rather than merge it. Basically, my reason is that I want to keep this example as simple as possible. While I really like the idea of having Parallels support in general, I think it will add a bit more complexity to the Vagrantfile than I'd like. Since this is a salt-vagrant-demo I think I'll keep it Vagrant-centric for now and keep things as simple as possible.

Thanks so much for your PR and the time you put into it. I'd be open to having another repo that includes more complicated examples if you think that would be helpful. Let me know what you think.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UtahDave/salt-vagrant-demo/pull/16#issuecomment-225295447, or mute the thread https://github.com/notifications/unsubscribe/AAgIUC5akCiudp5_q5BH4tsGLzIrsuL6ks5qKdF5gaJpZM4GGC9o .