Pre-defined minion OSes and alternate SaltStack home

UtahDave / salt-vagrant-demo

Demo of Salt in Vagrant. 1 master and 2 minions

Apache License 2.0

247 stars 191 forks source link

Pre-defined minion OSes and alternate SaltStack home #37

Closed mbrannigan closed 6 years ago

mbrannigan commented 7 years ago

I made a few alterations:

There are now pre-defined minions for Ubuntu (trusty and xenial) as well as CentOS (6 / 7).
Read an environment variable SALTSTACK_HOME to provide a way to override the location of the /srv directory.

Not sure if you'd be interesting in merging this. Having these available helps when I am developing for SaltStack across multiple OSes. Thanks for the project!

UtahDave commented 6 years ago

Hi @mbrannigan I like the ideas you have in this PR. I just merged https://github.com/UtahDave/salt-vagrant-demo/pull/38 which does a little bit of what you describe here.

I don't want to default to building more than 3 VMs at once so that it's not too burdensome to spin up the project. I think the PR I linked to above can be improved to allow for more VMs and more OSes. I'd be willing to consider adding that functionality to the new code, but I'm going to close this PR for now. Let me know what you think. Thanks!

mbrannigan commented 6 years ago

Hey @UtahDave sounds good. I agree that waiting for the project to spin up all those possible VMs is a tad bit cumbersome. I really like the approach taken in #38. Thanks again for the project and let me know if I can help out in any other way.