search

UtahDave / salt-vagrant-demo

Demo of Salt in Vagrant. 1 master and 2 minions
Apache License 2.0
247 stars 191 forks source link

modify Vagrantfile to make it more flexible, scalable and easy extend… #38

Closed ghost closed 6 years ago

ghost commented 7 years ago

…ible

fix centos issues for virtualbox 5.1.21 update used ubuntu box version from 14.04 to 16.04 add bridged networking option

marco-m commented 7 years ago

Hello @UtahDave, would you consider this PR? I like how it makes the Vagrantfile more parametric. On the other hand it contains multiple independent changes, maybe you could ask @readonlysc to split in separate PRs ?

ghost commented 6 years ago

@marco-m how should I split my pull request? I mean in which two parts? thank you for your comment.

marco-m commented 6 years ago

@readonlysc To me, the most important change is the parametric approach. So first PR could be only that, without the bridge and keeping the Ubuntu VM. Second PR could be the bridge, 3rd PR the addition of Centos.

ghost commented 6 years ago

@marco-m I did the changes, i think know it should be ready for the merge thank you for your tipps

marco-m commented 6 years ago

@readonlysc You are welcome! Let's see if @UtahDave is still interested in this repo...

UtahDave commented 6 years ago

Thanks for this update! Sorry it took me a while to get to test it.

marco-m commented 6 years ago

Thanks!