search

UtahDave / salt-vagrant-demo

Demo of Salt in Vagrant. 1 master and 2 minions
Apache License 2.0
247 stars 191 forks source link

Add libvirt support for Vagrantfile #48

Closed g2g closed 4 years ago

UtahDave commented 4 years ago

Hi @g2g ,

Thanks for the addition!

In general, I want to keep this salt-vagrant-demo simple, but this looks interesting.

Can you add some info to the README on how to use this? Specifically, what dependencies this has and specific command line examples of how to run this with libvirt vs virtualbox.

Also, will this continue to default to virtualbox?

UtahDave commented 4 years ago

Hi, @g2g

I really appreciate your PR adding support for libvirt. After considering this PR for a while I think I'm not going to merge it. The purpose of this repo is to demo Salt with Vagrant. Adding support for other virtualization technologies is a great idea, but it does add increased complexity which I think will make it somewhat more difficult for new users to understand what's going on.

I would be open to creating another repo that showcases how to use this with many different virtualization technologies, but I think that repo isn't this repo.