search

Utkarsh1308 / TabOverSpace

http://aqueous-lowlands-03932.herokuapp.com/
GNU Affero General Public License v3.0
0 stars 1 forks source link

templates/: Add base.html and use it #108

Closed KVGarg closed 5 years ago

KVGarg commented 5 years ago

Please review carefully! Check if any important thing missed out, while re-using the base.html as a lot of code is removed. So, there may be chance that some important got deleted up! Also, future fixes which need to be made depending upon frameworks:

  1. In explore section, a explore.js is getting used (created in this commit), and the background image url defined for an article is using a relative path but the image isn't getting shown while running on server (it says 404 error).
  2. A lot of css - properties (inline as well as stylesheet) were duplicated or overwritten, so removed unwanted css! Check if that thing matters or not!
Utkarsh1308 commented 5 years ago

I'm getting a different UI for the practice sections Notice the attempt button and the difficulty.

Screenshot (16)

Utkarsh1308 commented 5 years ago

Also Remove simulation from the Navbar please

Utkarsh1308 commented 5 years ago

In the explore section the subtopics don't have any borders. Leave it maybe. I will fix it with my explore PR

KVGarg commented 5 years ago

I'm getting a different UI for the practice sections Notice the attempt button and the difficulty.

The ss you attached to ur comment is of the changes of this PR or of ur changes? bcoz I'm also getting the same design as in ss attached

Utkarsh1308 commented 5 years ago

The screenshot I attached is for this PR. For the master repo the info for each question is inside it's card.

KVGarg commented 5 years ago

OK! I will into that thing. Maybe that just need moving of statements in the div block above that one.

Utkarsh1308 commented 5 years ago

LGTM rebase please