search

UtkarshVerma / dwmblocks-async

An efficient, lean, and asynchronous status feed generator for dwm.
GNU General Public License v2.0
232 stars 87 forks source link

Fix mouse click handling #3

Closed dimaglushkov closed 3 years ago

dimaglushkov commented 3 years ago

Hello! First of all, thanks for your great work! I've switched to dwm a few days ago and patched it with a few patches including dwm-statuscmd and dwm-systray. After that I've tried default dwmblocks with dwmblocks-statuscmd patch and it worked ok, but I've experienced a lot of block flickering when for example using the mouse wheel to update the block. After a few tries to fix it, I've found your dwmblocks build and it had no flickering issue, but unfortunately, mouse button clicks weren't working for me. Therefore I've fixed it with a few lines of code changed.

After that I was curious if unworking mouse block clicks on your build are the result of me unproperly applying patches or the result of something else, so I've downloaded clear dwm build, patched it with dwm-statuscmd, and tried your build of dwmblocks on it, but mouse block clicks weren't working properly, however my fix did it for me.

*Recreated PR since the last one was looking for the wrong branch

UtkarshVerma commented 3 years ago

@dimaglushkov Thanks for the PR. There was a bug with the async behaviour of the statusbar. I didn't have time so I switched to one of the older commits back then and forgot to update the README. I apologize if you faced any inconvenience because of that. Thanks again for taking your time to fix this :+1: . I tested it locally for now, and it works fine.