search

UtkarshVerma / dwmblocks-async

An efficient, lean, and asynchronous status feed generator for dwm.
GNU General Public License v2.0
232 stars 87 forks source link

improve Makefile and config.h #34

Closed ayoubelmhamdi closed 1 year ago

ayoubelmhamdi commented 2 years ago

make again if the config.h change too

- $(BIN): main.o
+ $(BIN): main.o config.h

move the BLOCK macro and Block struct to config.h, which helps to show the correct diagnostic by clangd and ccls

UtkarshVerma commented 2 years ago

Hello, thank you for the PR. However, I intentionally don't include the definitions in config.h as it has to be really minimal. People are expected to modify it, therefore I like to keep the internals of dwmblocks-async hidden away from there.

ayoubelmhamdi commented 2 years ago

so, you can use another file to call it from config .h and main.c like util.h or modifier the Makefile to tell clang where this definition

UtkarshVerma commented 1 year ago

Hi, thank you for the PR. However, I will be closing it since this is already being worked on in the new-org branch and changes will be integrated to main once I've solved a couple of TODOs with the file organisation.