Close issue 38, added an ability to specify statusbar/ directory.

UtkarshVerma / dwmblocks-async

An efficient, lean, and asynchronous status feed generator for dwm.

GNU General Public License v2.0

224 stars 87 forks source link

Close issue 38, added an ability to specify statusbar/ directory. #41

Closed lisp3r closed 1 year ago

lisp3r commented 1 year ago

Added changes from https://github.com/UtkarshVerma/dwmblocks-async/issues/38.
Added an ability to specify scripts directory through SCRIPTS_DIR value.

I used to add my scripts directory into $PATH which isn't a good practice. So I made this little patch.

ListeriaM commented 1 year ago

also possible is:

#ifdef SCRIPTS_DIR
#define BLOCK(cmd, interval, signal) \
    { SCRIPTS_DIR "/" cmd, interval, signal }
#else
#define BLOCK(cmd, interval, signal) \
    { cmd, interval, signal }
#endif

which seems simpler IMO. It may add an extra '/' which doesn't affect the behavior, but it is more robust.

UtkarshVerma commented 1 year ago

Hi guys, thanks for taking out the time on working towards this issue. However, I'll need to close this PR since I have found a fix for #38 and it is implemented in the new-org branch. I'm facing a few hiccups from a code organization point of view, but technically there is no problem, as far as I've tested it.