search

UtkarshVerma / dwmblocks-async

An efficient, lean, and asynchronous status feed generator for dwm.
GNU General Public License v2.0
224 stars 87 forks source link

correct includes #52

Closed ssnailed closed 9 months ago

ssnailed commented 9 months ago

Various includes in this project are incorrect and cause problems when building on systems not using glibc (such as alpine). Since I use this project and am otherwise very happy with it I thought I'd make a pull request with my changes.

UtkarshVerma commented 9 months ago

Thanks for the PR. Is there any way I could reproduce the behaviour you observed?

ssnailed commented 9 months ago

If you have docker installed you can run this command:

docker run alpine /bin/sh -c '\
apk add --no-cache build-base gcc xcb-util-dev pkgconfig git \
&& git clone https://github.com/UtkarshVerma/dwmblocks-async \
&& cd dwmblocks-async \
&& make'

Compilation succeeds with my changes which can be tested with this command:

docker run alpine /bin/sh -c '\
apk add --no-cache build-base gcc xcb-util-dev pkgconfig git \
&& git clone https://github.com/ssnailed/dwmblocks-async \
&& cd dwmblocks-async \
&& make'
UtkarshVerma commented 9 months ago

The changes are now merged. Thanks for the PR, learned something new.