Closed ghost closed 5 years ago
@jhabdas I'm not well versed with licensing as such. Shouldn't his name in the README be enough? After all I'm not using his theme as it was. I'm fact there are multitudes of distinctions between our themes currently. Therefore shouldn't it be correct for me to put my name?
You should probably get to know the MIT license a little better if you plan on using it in your work.
Even if you based your work off theirs it doesn't make yours unique (which is probably what prompted you to add their name to your README
). You simply need to update your LICENSE file with their name (and year, if present) in the copyright line. Here's an example. If you have questions about how to use software licenses I recommend https://opensource.stackexchange.com.
And I can see you've already discovered the last link I mentioned.
@jhabdas Thanks. I'll be including it shortly when I'll be back on my PC today.
Thanks for your diligence and FWIW software licenses with restrictions and conditions such as (well, almost all of them—except for one) are my least favorite part of open source.
You've got it backwards. I should be the one thanking you for pointing out the license mistake or else I might have faced hurdles in the near future. Btw, licenses are my least favourite as well.
Hi. I was looking over your
LICENSE
file and noticed you haven't includedCopyright (c) 2017 Yue Yang
which is a requirement of the license. You should probably add that as there are now 58 forks of your work which may be infringing the rights of the original creator.