UtkarshVerma / hugo-dream-plus

:rainbow: An upgraded version of the Hugo "Dream" theme with tons of new features.
http://dream-plus-posts.netlify.com
MIT License
68 stars 66 forks source link

add additional params background.bgColor to customize background #61

Closed hpcsc closed 5 years ago

hpcsc commented 5 years ago

Motivation and Context

At the moment, the theme only allows to customize the background in 2 ways:

For my site, neither of these options are what I want. I just want a simple color for the background color and not changing every time. So I updated the code to allow 3rd way of configuring the background color: by passing the color directly

Description

I added another parameter background.bgColor to allow user specify the background color directly I also renamed the existing variable colorBG to randomizeBgColor to make the behavior clear. This is a breaking change but should be simple enough to update Both bgColor and randomizeBgColor set the same style property --background which will be used directly in css background Behavior of bgList is still the same

Please help to review my PR

UtkarshVerma commented 5 years ago

@hpcsc Thanks for the PR. I appreciate your effort but sadly I don't currently have the time to review the PR myself. However, I'll do so after about a month from now. Hoping you won't mind.

hpcsc commented 5 years ago

@UtkarshVerma sure, no worry. I forked your repo so the PR is not blocking me