search

UtkarshVerma / hugo-dream-plus

:rainbow: An upgraded version of the Hugo "Dream" theme with tons of new features.
http://dream-plus-posts.netlify.com
MIT License
68 stars 66 forks source link

Social Link missing facebook #66

Closed coreychen71 closed 5 years ago

coreychen71 commented 5 years ago

Describe the bug
I setting Social Link an facebook in Config.toml, but I can't see icon in web site.

To Reproduce
Simply add facebook = username in the config file and run the website, and look for facebook

Expected behavior
Providing facebook username should cause link to facebook account to appear on the website

Hugo version
Hugo Static Site Generator v0.55.5/extended darwin/amd64 BuildDate: unknown

UtkarshVerma commented 5 years ago

@coreychen71 You are correct about that. I have accidentally missed specifying the social parameters for Facebook in the social partial. I will keep this in mind. By the way, I'm currently revamping the site which is preventing me from making any changes to the HEAD of this repo, since the local repo is multiple commits ahead and I don't want to have a headache while merging the two. Therefore please hold out a couple of weeks without this feature, after which you'll surely be able to add the Facebook social link.

UtkarshVerma commented 5 years ago

Here's the local fix which you may use as a workaround for now. In the social.html partial, add a new slice element for "facebook" in the $icons variable, and similarly, add a new slice element "https://www.facebook.com/" to the $links variable and "Facebook" in $sites.

coreychen71 commented 5 years ago

In the way you provided it, Facebook has taken care of it, and I've added Instagram to it.

thanks.