fix: timer-not-working #101

KSSaiTeja commented 1 year ago

Related Issue

Closes: #101 that will be closed through this PR

Describe the changes you've made

Give a clear description what modifications you have made

I have created audioRef to reference the <audio>element in the component. handlePlaySound plays the audio if it's not already playing and starts the timer. handleStopSound stops the audio if it's playing, resets the timer, and sets soundPlaying to false to indicate that the sound has stopped. and the timer stopped issue is also fixed

Type of change

Bug fix

What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

yes! i tested it and it absolutely working fine when i am tested. if this PR gets accepted i will suggest some more new features i have and i will contribute more to this. Please review the changes and accept the PR. sorry i worked without assigning the issue the task to me. As it is not mentioned in contributing guidelines so that's why i raised a PR. As i am a beginner i don't know if it is correct or not, if it is not correct excuse me for this time, and sorry for disrupting the community guidelines.

Describe how have you verified the changes made

by running the project locally, npm install --legacy-peer-deps after that making some file changes and then npm start

Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Video Proof of what i have done (ignore the interruption they are just hydration errors, they will not come in production.)

https://github.com/Utkarshn10/Focusly/assets/130981122/2b8b7d52-c06e-45fd-b106-551feb0d9a40

previoulsy the timer fluctuates and not worked when morethan one music playing. but i fixed this, to any one of the music is playing the timer will run, when no music is playing the timer will stop.

please consider my PR :D

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @Utkarshn10 on Vercel.

@Utkarshn10 first needs to authorize it.

KSSaiTeja commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @Utkarshn10 on Vercel.

@Utkarshn10 first needs to authorize it.

sorry accidentally clicked, i will not make these mistakes anymore in the future. consider my PR and not my mistakes. as a beginner i am exploring all of these. not going to spoil anything

Utkarshn10 commented 1 year ago

Thanks @KSSaiTeja for contributing to Focusly :)

KSSaiTeja commented 1 year ago

Thanks for accepting my PR. @Utkarshn10 can i share it on my socials.. and also i have some ideas to improve focusly.. to more beautiful UI.. i want share those ideas with you. could you please tell me how can i share those ideas to you

KSSaiTeja commented 1 year ago

Thanks @KSSaiTeja for contributing to Focusly :)

my Pleasure..

Utkarshn10 / Focusly