search

Utkarshn10 / Focusly

Open source app to remain focused during your deep work sessions. Built using ReactJS
https://focusly.vercel.app/
MIT License
35 stars 44 forks source link

Timer behavior fix #106

Closed Utkarshn10 closed 9 months ago

Utkarshn10 commented 10 months ago

Describe the bug Timer doesn't run once its stopped or it continous even when stopped.

To Reproduce Play a sound. Pause it and play another sound.

Expected behavior Timer should only run when a sound is playing.

KSSaiTeja commented 10 months ago

can i work on this issue..?

Utkarshn10 commented 10 months ago

Sure. Issue assigned.

KSSaiTeja commented 10 months ago

thanks for assigning.. i have an idea to fix this issue..

if one sound is playing, another will automatically stop in that way i think this will fix.

if you have any idea please share it i will work according to that

Utkarshn10 commented 10 months ago

This can only be implemented if the selected tab is lo-fi as in other tabs(specifically focus) we need to allow multiple sounds to be played together.

KSSaiTeja commented 9 months ago

Can you mention file changes to work on.. this leads to work easy for me

Utkarshn10 commented 9 months ago

Changes are to be made around timer context and wherever it is being used.

Can you mention file changes to work on.. this leads to work easy for me

KSSaiTeja commented 9 months ago

@Utkarshn10 raised a PR. Hope you wil merge my PR..!!

KSSaiTeja commented 9 months ago

@Utkarshn10 May i know the status of my PR

Utkarshn10 commented 9 months ago

@KSSaiTeja have reviewed it and have also suggested some changes. Thanks

KSSaiTeja commented 9 months ago

@Utkarshn10 fixed the changes you've requested. Please review again and merge my PR