Open cookie33 opened 2 months ago
Warnings should be treated as errors, unless you're sure the warning is irrelevant.
As for using -fcommon
, I'd say it's not a proper fix. My guess is the code has ODR violations which need to be addressed. Based on the implementation, it looks like all that's needed is to mark the declaration as extern
.
The line of interest: https://github.com/UtrechtUniversity/davrods/blob/2a3cb96643802fe3d80a648c44819b147465c689/src/mod_davrods.h#L35
Suggested change:
-module AP_MODULE_DECLARE_DATA davrods_module;
+extern module AP_MODULE_DECLARE_DATA davrods_module;
Thanks.
The build passes with the proposed update on Centos7 with iRODS 4.3.1 The build passes with the proposed update on el9 with iRODS 4.3.2
Hi,
We needed a version of davrods for iRODS 4.3.2 on el9. We build it ourselves.
We did following:
update CMakelist.txt with version 4.3.2
create makefiles
build
Fixed as follows:
And then it builds
And we are able to create a package from it:
Two questions:
Greetings
Cookie33