UtrechtUniversity / yoda

A system for reliable, long-term storing and archiving large amounts of research data during all stages of a study.
https://utrechtuniversity.github.io/yoda/
GNU General Public License v3.0
42 stars 26 forks source link

[BUG] Contributor ORCIDs on landing page are not shown as a clickable links #418

Closed peer35 closed 1 week ago

peer35 commented 1 month ago

Is there an existing issue for this?

Current Behavior

Not all ORCIDs are shown as clickable links. Looking at the Yoda metadata I see this only happens with contributors, orcids of creators are shown correctly.

See for example the ORCIDs shown on: https://publication.yoda.vu.nl/full/VU01/11WJKE.html https://publication.yoda.vu.nl/full/VU01/T0M09U.html

Expected Behavior

If a person identifier can be shown as a clickable link it should be.

Steps To Reproduce

Publish a dataset with a Contributor with an orcid as person identifier.

Environment

- Yoda:v1.9.0-rc.6
- Ansible:-
- Operating System:all
- Browser:all

Anything else?

Looks like a small oversight in the template https://github.com/UtrechtUniversity/yoda-ruleset/blob/fdc13977d90c983c03684bc6ea038d50c6f68643/templates/landingpage.html.j2

compare lines 402-410 with 455-457

stsnel commented 1 month ago

Thank you for the bug report. We have registered it in our internal bug tracker as ticket nr. YDA-5712

lwesterhof commented 1 week ago

Fixed in https://github.com/UtrechtUniversity/yoda-ruleset/commit/77d8a177f79ceb839d6da59c7b0a6a9aa0c7e0a4