UtrechtUniversity / yoda

A system for reliable, long-term storing and archiving large amounts of research data during all stages of a study.
https://utrechtuniversity.github.io/yoda/
GNU General Public License v3.0
44 stars 26 forks source link

[BUG] Notifications being emailed when user not part of Yoda anymore #456

Open Danny-dK opened 2 months ago

Danny-dK commented 2 months ago

Is there an existing issue for this?

Current Behavior

As I'm leaving WUR, I removed all my personal email addresses from Yoda@WUR. One of those email addresses I did not mark notifications as 'done' in the webportal. Hence I received those notifications weekly while that email address still was associated with a research group (was mainly for testing and keeping reminders). However, once I removed that email address from all research groups using the group manager of the webportal, that email address still received a weekly digest of the open notifications. This can then be stooped by re-adding that email address and changing setting while logged in with that email address (for example to not send any notifications through email).

Expected Behavior

To stop open notifications from being send when an email address is not associated with any research group.

Steps To Reproduce

Sign in with private email address. Make sure setting indicate to email daily or weekly digest of notifications. Submit something to vault. Have submittal be rejected to create notification that should be send by email to the user according to their setting (daily or weekly digest). Remove that email address from all research groups without having the notifications be marked as 'done'. Wait until the removed email address from Yoda still gets the daily or weekly digest of notification that were not marked as done.

Environment

- Yoda: Yoda@WUR (I believe it is Yoda-release-1.9)
stsnel commented 1 day ago

Thank you for the bug report. We have created an internal ticket to limit repeat notifications for unread notifications (YDA-5948). That should also address this issue. The ticket hasn't been assigned a version milestone yet.