UvA-FNWI / GradeTool

Grade calculation/submission tool for UvA
1 stars 0 forks source link

Blocked students shouldn't be able to receive grades via Excel #147

Closed c-wegman closed 1 year ago

c-wegman commented 1 year ago

Component

Grade list

Summary

If giving a grade to a student has been blocked it is no longer possible to manually enter a grade. However, if you upload the grade via Excel, you get to see the grade for the student, but the grade is not transferred to SIS. This should not be possible. If giving a grade to a student is blocked it should also be blocked when a grade is uploaded via Excel.

Steps to reproduce

  1. Block a student from receiving a grade
  2. Upload an Excel file with a grade for the student
  3. See that there is a grade for the student and it isn't blocked

Reported by

Carry (FEB) https://teams.microsoft.com/l/message/19:863e33c7d71a47e4b8a9b9c808e36a6a@thread.tacv2/1666873560641?tenantId=a0f1cacd-618c-4403-b945-76fb3d6874e5&groupId=b96c398c-fea4-40c7-976e-b512879e106c&parentMessageId=1666873560641&teamName=Implementatie%20Cijferregistratieapplicatie&channelName=FEB&createdTime=1666873560641&allowXTenantAccess=false