search

UweKeim / ZetaLongPaths

A .NET library to access files and directories with more than 260 characters length.
https://nuget.org/packages/ZetaLongPaths
MIT License
142 stars 28 forks source link

Latest package version v1.0.9.41 has dependency to JetBrains.Annotations v1.0.0 #38

Closed Lorilatschki closed 2 years ago

Lorilatschki commented 2 years ago

The latest package has a Dependency to JetBrains.Annotations 1.0.0 which leads to a compiler warning:

warning NU1603: ZetaLongPaths 1.0.9.41 depends on JetBrains.Annotations (>= 1.0.0) but JetBrains.Annotations 1.0.0 was not found. An approximate best match of JetBrains.Annotations 6.1.0 was resolved.

...
<dependencies>
  <dependency id="JetBrains.Annotations" version="1.0.0" />
</dependencies>
...

On https://www.nuget.org/packages/JetBrains.Annotations there is no matching version. Can you please remove this dependency since it is not required as a runtime dependency?

UweKeim commented 2 years ago

Sounds reasonable.

I guess, I could add it as a development dependency? Or would you recommend to completely remove it?

Lorilatschki commented 2 years ago

In version 1.0.7.41 it was not part of the nuspec file at all. So I would recommend to completely remove it.

Any idea why this was added to the nuspec?

UweKeim commented 2 years ago

OK, thanks.

I've added it, because I did think it was necessary, not understanding that the compiler/linker would probably remove all references to this library upon compilation.

A new version 1.0.10.41 was just published to NuGet.

Lorilatschki commented 2 years ago

Great! Thanks for the quick fix!