search

UweTrottmann / SeriesGuide

Track your favorite TV shows and movies on Android devices.
https://seriesgui.de
Apache License 2.0
1.97k stars 402 forks source link

imdb link on episode links to show on imdb #792

Closed flabbamann closed 3 years ago

flabbamann commented 3 years ago

Describe the bug If I click on the imdb link on an episode the link leads to the show on imdb, even if the episode has the imdb id added on tmdb. This only happens on shows added from tmdb. On shows migrated from tvdb the links are correct.

To Reproduce Steps to reproduce the behavior:

  1. Add a show from tmdb that has imdb links for the episodes (e.g. Mr Robot)
  2. Click on the IMDB link on an episode
  3. The link leads to the show on imdb

Expected behavior The imdb link on an episode should link to the corresponding episode entry on imdb, if the id is added on tmdb.

Smartphone (please complete the following information):

UweTrottmann commented 3 years ago

Sorry, this works as expected. TMDb does not have IMDB IDs on the episode level.

I guess it makes sense to remove the button from the episode screens?

flabbamann commented 3 years ago

It does have IMDB IDs per Episode :) grafik https://www.themoviedb.org/tv/456-the-simpsons/season/32/episode/1/edit?active_nav_item=external_ids

https://developers.themoviedb.org/3/tv-episodes/get-tv-episode-external-ids

UweTrottmann commented 3 years ago

Oh, thanks. I guess I decided against querying external IDs for each episode then to avoid overloading the TMDb API.

Keeping this open to add support for e.g. on demand fetching of external IDs. Though I'll be honest and say this isn't a priority as the data source is TMDb.

UweTrottmann commented 3 years ago

With the next update SeriesGuide will load the episode ID on demand from TMDb. If it's not available it will still use the show ID (if that is available).