search

UweTrottmann / SeriesGuide

Track your favorite TV shows and movies on Android devices.
https://seriesgui.de
Apache License 2.0
1.96k stars 400 forks source link

Remove code duplication and SuppressLint warning #820

Closed ippschi closed 2 years ago

ippschi commented 3 years ago

On my attempt to include a new dialog fragment for a warning I used this fragment as a source for copying. I had to change the string resource twice which made me think about reducing duplication (and also removing the SuppressLint warning) in this fragment.

ippschi commented 3 years ago

@UweTrottmann I would be happy if you would add the hacktoberfest-accepted label to this PR. https://hacktoberfest.digitalocean.com/

UweTrottmann commented 3 years ago

Thanks! But I don't like this change, it seems to just avoid the lint error because the linter isn't smart enough to understand the elvis operator. So it might pop up again at any later time if the analysis becomes smarter.