Do not sync Cloud/Trakt on recoverable show update failures.

[UweTrottmann]

• Retry updating a show right away if failure due to recoverable network error (connect issue, timeout, ...).
• Stop sync if updating even a single show fails (unless it is not found on TMDB).
• Fix to only update a shows last updated timestamp after seasons and episodes updated.
• Keeps backing off on 5+ failures instead of reverting to default sync interval (to avoid hammering servers that are potentially down or have issues). Also add first retry after min. 2 minutes.

This isn't much better, but better than the current situation. With Cloud sync it can still happen that a show is missing episodes because it is not considered for updating because it recently was.

Tasks

• ~Maybe move DoesNotExist error down to TmdbTools.~ No, it's not always an error.
• ✔ Report if body is null.
• ✔ Introduce own result type for getShowDetails.
• ✔ Walk through updateShow() child functions and migrate to UpdateResult.
  • Add service type to UpdateResult errors, maybe change to Result API.
• ~Thread.sleep() might not work during SyncAdapter sync?~ Works fine. Still unsure how interrupted due to timeout prevents sleep (or if this was a coincidence). Then retrying on timeout wouldn't work right now. Actually, looks like the system is cancelling the sync after all. From AbstractSyncAdapter docs: "Similarly the framework will attempt to determine whether or not an adapter is making progress by monitoring its network activity over the course of a minute. If the network traffic over this window is close enough to zero the sync will be cancelled. [...] A sync is cancelled by issuing a Thread.interrupt() on the syncing thread."

  java.io.InterruptedIOException: interrupted
  at okio.Timeout.throwIfReached(Timeout.kt:98)
  at okio.OutputStreamSink.write(JvmOkio.kt:50)
  at okio.AsyncTimeout$sink$1.write(AsyncTimeout.kt:103)
  at okio.RealBufferedSink.flush(RealBufferedSink.kt:267)
  at okhttp3.internal.http2.Http2Writer.flush(Http2Writer.kt:120)
  at okhttp3.internal.http2.Http2Connection.newStream(Http2Connection.kt:268)
  at okhttp3.internal.http2.Http2Connection.newStream(Http2Connection.kt:225)
  at okhttp3.internal.http2.Http2ExchangeCodec.writeRequestHeaders(Http2ExchangeCodec.kt:76)
  at okhttp3.internal.connection.Exchange.writeRequestHeaders(Exchange.kt:59)
  at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:36)
  at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
  at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
  at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
  at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:95)
  at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
  at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
  at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
  at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
  at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
  at com.uwetrottmann.trakt5.TraktV2Interceptor.handleIntercept(TraktV2Interceptor.java:44)
  at com.battlelancer.seriesguide.traktapi.SgTraktInterceptor.intercept(SgTraktInterceptor.java:27)
  at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
  at com.uwetrottmann.tmdb2.TmdbInterceptor.handleIntercept(TmdbInterceptor.java:59)
  at com.battlelancer.seriesguide.tmdbapi.SgTmdbInterceptor.intercept(SgTmdbInterceptor.kt:19)
  at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
  at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201)
  at okhttp3.internal.connection.RealCall.execute(RealCall.kt:154)
  at retrofit2.OkHttpCall.execute(OkHttpCall.java:204)
  at retrofit2.DefaultCallAdapterFactory$ExecutorCallbackCall.execute(DefaultCallAdapterFactory.java:108)
  at com.battlelancer.seriesguide.tmdbapi.TmdbTools2.getShowAndExternalIds(TmdbTools2.kt:109)
  at com.battlelancer.seriesguide.ui.shows.ShowTools2.getShowDetails(ShowTools2.kt:123)
  at com.battlelancer.seriesguide.ui.shows.ShowTools2.updateShow(ShowTools2.kt:612)
  at com.battlelancer.seriesguide.ui.shows.ShowTools.updateShow(ShowTools.java:81)
  at com.battlelancer.seriesguide.sync.ShowSync.sync(ShowSync.kt:69)
  at com.battlelancer.seriesguide.sync.SgSyncAdapter.onPerformSync(SgSyncAdapter.kt:114)
  at android.content.AbstractThreadedSyncAdapter$SyncThread.run(AbstractThreadedSyncAdapter.java:334)

[github-actions[bot]]

Unit Test Results

10 files  ±0  10 suites  ±0   8s :stopwatch: -2s 25 tests ±0  25 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 217dab7c. ± Comparison against base commit 192f8aa3.

:recycle: This comment has been updated with latest results.