search

UweTrottmann / SeriesGuide

Track your favorite TV shows and movies on Android devices.
https://seriesgui.de
Apache License 2.0
1.96k stars 400 forks source link

Added Material You switches in settings #854

Closed GustavoASantos closed 2 years ago

UweTrottmann commented 2 years ago

Thanks! Is this the official way to do this? I'd rather not make modifications to UI provided by standard libraries as these become hard to maintain.

GustavoASantos commented 2 years ago

No, there isn't an official way yet as far as I'm aware. This is just what I am doing for now to match Google's look. I understand that, do you want me to close the pr?

UweTrottmann commented 2 years ago

Wait, I just checked the settings screens and they already use the new color scheme and style. What device or Android version did you use to test this?

image

GustavoASantos commented 2 years ago

You're right but that's not how it was looking to me, I must've changed something and made it wrong. Sorry about that. I used a Pixel 6. Give me a couple of days and I'll get back to you on this

GeoZac commented 2 years ago

I think the issue being "tried" to be addressed is this Settings app in android 12 has a distinct set of switch widgets available from the framework(provided by SettingsLib package)

UweTrottmann commented 2 years ago

@GeoZac Ah, thanks. So won't accept this PR then. Will stick with the style from the official Material Design Components library for Android.