UweTrottmann / SeriesGuide

Track your favorite TV shows and movies on Android devices.
https://seriesgui.de
Apache License 2.0
1.96k stars 400 forks source link

Migrate onBackPressed to OnBackPressedDispatcher #885

Closed UweTrottmann closed 1 year ago

UweTrottmann commented 1 year ago

To future me: save yourself the work, this is just deprecated for the still to be released predictive back feature. It's unlikely the simpler, old API will ever be removed.

https://developer.android.com/reference/android/app/Activity#onBackPressed() https://developer.android.com/guide/navigation/navigation-custom-back

Notable: when adding a callback to the OnBackPressedDispatcher, have to explicitly call finish() instead of super.onBackPressed() previously.

github-actions[bot] commented 1 year ago

Test Results

27 tests  ±0   27 :heavy_check_mark: ±0   13s :stopwatch: +2s 12 suites ±0     0 :zzz: ±0  12 files   ±0     0 :x: ±0 

Results for commit 8c98ce98. ± Comparison against base commit 82fbaf7a.