Uysim / pagy-cursor

Cursor pagination with pagy for Ruby On Rails
MIT License
126 stars 23 forks source link

Incompatible with Pagy 5 #26

Closed MarcelEeken closed 2 years ago

MarcelEeken commented 3 years ago

Pagy 5.0 was released just a couple of days ago, and that has a breaking change with regards to Pagy::VARS. This variable has been renamed to Page::DEFAULT as can be seen in this changelog https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md#version-500

Uysim commented 3 years ago

@MarcelEeken I'll look into it as soon as possible. PR is welcome

MarcelEeken commented 3 years ago

If I have some time I will see if I can open one

Ahmedhemaz commented 2 years ago

when will pagy 5 support be merged?

Uysim commented 2 years ago

I am sorry for the delay. This support is schedule to release on 9 Feb 2022. FYI @Ahmedhemaz and @MarcelEeken

Ahmedhemaz commented 2 years ago

Thanks a lot for your contributions

Uysim commented 2 years ago

Checkout our release 0.5.0

MarcelEeken commented 2 years ago

Thank you for the fix