search

UziTech / atom-jasmine2-test-runner

A test runner for Atom
https://www.npmjs.com/package/atom-jasmine2-test-runner
MIT License
3 stars 2 forks source link

Make pathwatcher a optional dependency #17

Closed lgeiger closed 7 years ago

lgeiger commented 7 years ago

Thanks for maintaining this module!

v0.7.1 added pathwatcher as a dependency. Since it is a native module it can cause quite some pain during install for developers who don't have properly set up their compilers (mainly Windows) or use Atom beta.

It would be cool to make it a optional dependency. What do you think?

UziTech commented 7 years ago

Good call. I set all of the spec-helper dependencies as optional in v0.7.2.

If you do need pathwatcher to work on windows try deleting the node_modules folder and running apm i instead of npm i

UziTech commented 7 years ago

@lgeiger I took this a step further and started lazy installing the spec-helper dependencies in v0.8.0 so pathwatcher won't be installed at all unless it is set as a spec-helper.

Let me know if this has any issues. In testing it had a few issues on osx but I think those were just with the testing environment.