search

V-Sekai / godot-vrm

Importer/Exporter for VRM avatars and MToon shader. Available for Godot 4.1+ and 3.2+ in the Asset Library.
https://godotengine.org/asset-library/asset/2031
Other
287 stars 24 forks source link

Handle missing bone groups and collider groups #83

Closed fire closed 9 months ago

fire commented 12 months ago

Don't crash.

lyuma commented 11 months ago

Please create an issue with a test case or point to the part of the spec in which bones is optional inside of a bone group

lyuma commented 9 months ago

I understand the desire to follow defensive coding practices (be liberal in what you expect) but this is one specific place and it is solving a case of a non compliant document, and we will surely crash in other places even if we address this issue here.

What I've observed is other bugs in the godot-vrm export code will cause incomplete file to be written with errors such as missing keys. If I had to guess, this happened as a result of a failed export. I recently fixed some bugs with exports so perhaps that will help.

But for now I'll close the issue since there was no repro case and I can't evaluate it.