Multiple quick clicks on the "running button" will inevitably trigger a crash

V-Sekai / godot-whisper

An GDExtension addon for the Godot Engine that enables realtime audio transcription, supports OpenCL for most platforms, Metal for Apple devices, and runs on a separate thread.

MIT License

65 stars 6 forks source link

Multiple quick clicks on the "running button" will inevitably trigger a crash #69

Closed aiaimimi0920 closed 5 months ago

aiaimimi0920 commented 5 months ago

https://github.com/V-Sekai/godot-whisper/assets/153103332/c5abe9e6-8fc5-4ab6-8ae2-4001ab97ed1f

It should be related to the call to Thread

Ughuuu commented 5 months ago

Will check. Now that we are using thread in gdscript should be easier to change/investigate/fix.

Ughuuu commented 5 months ago

When unchecking, the thread doesn't wait for finish. Fixed in gdscript. I have opened a PR.

fire commented 5 months ago

We need to update the addon on the asset library right?

Ughuuu commented 5 months ago

In a bit, i will tell you after i make a release. Went away from pc after the pr and build failed, need to rerun it. On windows it falls intermittently at upload stage.