Closed bcaswelch closed 8 years ago
Hi @bcaswelch , we agree. After discussing with Lukas these are our proposed changes:
@LukasChen
Great job! :heart:
I increased margins and padding in the file: _portfolio.scss in .portfolio-section {
padding-top:50pt;
padding-bottom:10pt;
margin-top: 50pt;
padding-bottom: 10pt;
padding-top: 50pt;
margin-bottom: 100pt;
@bcaswelch Please check and advise if all is well now and if I can close this issue?
I just found that we overlooked to make the portfolio section title bigger. Will be done before we close the issue.
Looks good! Having it there when the page opens makes it much more noticeable.
I'm guessing its just a bug but the top navigation bar doesn't appear when on a desktop medium size window.
@bcaswelch
Thanks for your feedback. So we will close the issue once Lukas completes the open tasks :-)
The Top Navigation Bar on a window that is just wide enough to show it
The Top Navigation Bar on a window that is just not wide enough to show it. The Top Navigation Bar is turned off and replaced with the "Open Menu Item".
Once you click or tab that icon, the off canvas menu shows.
I wasn't the top navigation bar before (seemed to fix itself though).
Ah I did miss the menu icon! Guess I usually just scroll past the first page without noticing the opening. Like it though.
The issue is resolved as far as I can tell.
@bcaswelch
Thanks for your reply. About the behavior of the Main Menu:
I will close this issue once Lukas worked down the remaining open tasks.
In the end we removed the Side Bar Navigation. We loved its function, we loved its design. But it clashed with newly introduced wide backgrounds to portfolio titles and it made Navigation too complicated:
We found that Top Bar Navigation and Accordion Navigation is simply enough. By removing the Side Bar Navigation we reduced clutter on the page.
Showed my friend the website and she had a couple recommendations/observations.
Side Bar Navigation
When first pulled up fullscreen, didn't realize it appeared when she scrolled down. Thinking about it, it is cut away from everything else on the page and off in a corner. Might look at making it a bit bigger/noticeable.
Text Title
Felt the titles were too small compared to everything else (brought up that the title of each section was smaller than the 4 square progress bar). Making it bigger would help notify each new section since they all look fairly similar.
I'll throw some images in of specifics once I get done with class