search

V0idWa1k3r / SmartBackpacks

A backpack mod for minecraft that adds backpacks of varying sizes that can be upgraded with various upgrades.
GNU Lesser General Public License v3.0
6 stars 8 forks source link

Feature Request: Config for backpack sizes and number of upgrade slots for each backpack #11

Open Goldenlion5648 opened 5 years ago

Goldenlion5648 commented 5 years ago

I really like the mod and how many different upgrades there are. It seems like it could be cool for pack makers to be able to configure the backpack sizes and upgrade slots to fit the progression of the pack.

V0idWa1k3r commented 5 years ago

What about the GUIs? If I make the amount of slots configurable what happens to them? They are not modular(and can't really be modular).

Goldenlion5648 commented 5 years ago

Can you make it so that this config would only allow multiples of 9? Or maybe somehow make the textures dynamic so that they are created themselves? Or maybe an "X" is drawn over slots that cant be used or something similar? So assuming that people only wanted to lower the amount of slots in the inventory or upgrade slots then maybe an "X" would be drawn over the excess slots.

V0idWa1k3r commented 5 years ago

Can you make it so that this config would only allow multiples of 9

What about the ultimate backpack? That one has 13 slots per row. The config wouldn't work with it then.

Or maybe somehow make the textures dynamic so that they are created themselves?

I am afraid that's not really possible. It wouldn't work if someone configures the amount of slots to be higher than the GUI can stretch - it would go off-screen. It also screws with the positioning of buttons and slots. An ultimate backpack already uses the maximum-size texture possible without going off-screen on certain resolutions/gui scales. You could give me an example of a draconic chest that is bigger and I could give you a screenshot of that chest's GUI being unable to fit onto my screen.

So assuming that people only wanted to lower the amount of slots in the inventory or upgrade slots then maybe an "X" would be drawn over the excess slots.

What if they want to increase the amount of slots instead? If a feature like this is to be implemented it needs to handle every possible case.

Goldenlion5648 commented 5 years ago

Are you able to set a suggested limit like a lot of mods do in configs? For example [range: 1 ~ 9, default: 2] for the number of rows (each backpack would have this config), but not hard enforced (or enforced, either one). Maybe the ultimate backpack could be the only one not configurable since like you said it is already the max possible size?

V0idWa1k3r commented 5 years ago

I'll implement the ability to reduce the amount of slots for now. I'll see about the ability to increase the amount too but that will require a major rework of the gui system currently in the mod.

Goldenlion5648 commented 5 years ago

Thanks, I think reducing the number of slots would be a more common tweak wanted. Is this also including a number of upgrade slots config?

V0idWa1k3r commented 5 years ago

Yeah sure.