V10lator / SigPlugin

Signature patcher designed for Aroma
GNU General Public License v3.0
11 stars 0 forks source link

It doesn't work #1

Open ctrlaltdel-html opened 4 months ago

ctrlaltdel-html commented 4 months ago

After an Aroma update, whenever I try to open a game, it does not work!

nothor commented 3 months ago

I'm having probably the same issue:

Precondition:

Action:

Observed:

Healing

dkosmari commented 3 months ago

Try this fork: https://github.com/dkosmari/AromaSigPlugin

nothor commented 3 months ago

I will test it today and I will give you feedback.

nothor commented 3 months ago

Try this fork: https://github.com/dkosmari/AromaSigPlugin

I installed the last Inkay Beta compatible with Aroma +17 Inkay Beta

And replaced replaced SigPlugin 1.1 with your fork 1.2.

I'm not sure if the solution is the new Inkay or your fork, but now works as expected.

Thanks!

dkosmari commented 3 months ago
* I have noticed that the size has been increased a lot (from 5kB to 64kB). What are exactly the changes?

It says right there in the downloads page, it prints out messages to the log to show what's going on. That forces new parts of WUT to be linked into the executable, to send log messages through the network, making the executable bigger.

I updated the binaries, there are now two options: a smaller one, with no debug messages (SigPlugin.wps), and the one that prints the debug messages (SigPluginDebug.wps).

ctrlaltdel-html commented 3 months ago

Guys, an older one meant for Tiramisu worked.

eku commented 3 months ago

Try this fork: https://github.com/dkosmari/AromaSigPlugin

What about a PR?

V10lator commented 3 months ago

@dkosmari I really don't think logging is needed here. Anyway, what's the reason that your fork patches the H&S app, too?

To the Rest: I might incooperate some things from the fork next day but no guarantee. There are better sigpatches than the plugin available, like the setup module originally written for Tiramisu works just fine and there's even an updated fork available. Am not at home right now but will add links later.

dkosmari commented 3 months ago

@dkosmari I really don't think logging is needed here. Anyway, what's the reason that your fork patches the H&S app, too?

Logging was needed to figure out why it wasn't working. Aroma now starts and loads the plugins earlier than before, that's why the H&S app title ID is being reported to the plugin. I don't think you even need to check the title ID anyway.

nothor commented 3 months ago

@dkosmari I really don't think logging is needed here. Anyway, what's the reason that your fork patches the H&S app, too?

To the Rest: I might incooperate some things from the fork next day but no guarantee. There are better sigpatches than the plugin available, like the setup module originally written for Tiramisu works just fine and there's even an updated fork available. Am not at home right now but will add links later.

Could you add the link of the fork you talked about? Do you think is better to use Tiramisu Modules instead of Aroma Plugins, for the Aroma environment?

brainbug89 commented 1 month ago

I have the same issue since updating Aroma. 01_sigpatches.rpx and SigPlugin.wps are not working anymore.

Is there any fix?

anton-exe commented 3 weeks ago

Try this fork: https://github.com/dkosmari/AromaSigPlugin

this fork is gone for me