search

V2AI / Det3D

World's first general purpose 3D object detection codebse.
https://arxiv.org/abs/1908.09492
Apache License 2.0
1.48k stars 299 forks source link

lr update by learningrate_schedules_fastai ? #109

Closed Beastmaster closed 4 years ago

Beastmaster commented 4 years ago

in file: det3d/solver/learning_schedules_fastai.py: 61 self.optimizer.lr = lrs[-1] will not change lr used in optimizer. I think the proper way of updating lr is : self.optimizer.param_groups[0]['lr'] = lrs[-1]

tianweiy commented 4 years ago

the fastai optimizer wraps the original optimizer. There are some other class method to allow you to update lr in this way.

Beastmaster commented 4 years ago

There are 2 ways to build a optimizer: build_one_cycle_optimizer and build_optimizer. Optimizer built by "one_cycle_optimizer" is warped by fastai optimizer.

Beastmaster commented 4 years ago

Any further explaination for this question?