search

V2AI / Det3D

World's first general purpose 3D object detection codebse.
https://arxiv.org/abs/1908.09492
Apache License 2.0
1.48k stars 299 forks source link

Possible bug in points to voxel function #114

Open afroowoo opened 4 years ago

afroowoo commented 4 years ago

Hi, in the _points_to_voxel_kernel function below at

https://github.com/poodarchu/Det3D/blob/9fca2d94e4a138b6a2cd5d3fe4f4de38eb760306/det3d/ops/point_cloud/point_cloud_ops.py#L100-L101

shouldn't the loop continue instead of break?

By breaking the points loop we stop exploring new points that might have been assigned to an existing voxel.