Closed s-ryosky closed 4 years ago
Is it correct to use optimizer_config.type rather than optimizer_config.TYPE? It's mismatch with config file.
I have used ".type" rather than ".TYPE" because you have set "type" in config files. It depends the way to specify the attribute.
please keep it as Upper Case to indicate that thoese options are corresponding to config files.
Do you mean to change option names in config files to uppercase?
If so, then may I change all of them to uppercase? Or may I change only option names which are related to optimizer config to uppercase?
Now all option names in config files are written as lowercase and In your implementation the most of options are used as follows: https://github.com/poodarchu/Det3D/blob/56402d4761a5b73acd23080f537599b0888cce07/det3d/torchie/apis/train.py#L229-L230
YES, UPPER CASE is more suitable here
Fix.
It keeps option names of fastai_optimizer as uppercase. The others are lowercase.
please fix commit history, unrelated files are included in this merge.
sorry, I fixed it.
any feedback?
ref: #21