V4Vern / pe

0 stars 0 forks source link

Lack of input validation for get command #3

Open V4Vern opened 4 weeks ago

V4Vern commented 4 weeks ago

Description:

Inproper validation for get command (minor issue)

Steps to Reproduce:

get 3 3 2 get 3 / 3 get 3 3

Expected Result: Please provide a valid article index!!

Actual Result: It displays the results for article 3

image.png

nus-se-script commented 3 weeks ago

Team's Response

I think we did specify in our user guide that extraneous parameters will be ignored

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Lack of validation for quote command

Description:

Inproper validation for quote command (minor issue)

Steps to Reproduce:

quote //s.2 quote 24342 quote 2w1

Expected Result: It should print out an error messsage

Actual Result: It prints out the quote message

image.png


[original: nus-cs2113-AY2324S2/pe-interim#4] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

I think this shouldn't be an issue, we have specified that such parameters would be ignored in our user guide.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I feel that it should be not-in-scope because it's already specified in the UG. However, the error messages are not very consistent between different commands. For example, "suggest" does not take in parameters but it does print out error messages as show. However, "get" command" does not appear to do so. ![image.png](https://raw.githubusercontent.com/V4Vern/pe/main/files/1ba217c7-7385-4dff-952c-4003d10d9b50.png) ![image.png](https://raw.githubusercontent.com/V4Vern/pe/main/files/cf1c44f5-7f33-40b4-9def-17970eab03ff.png)