search

VAMDC / NodeSoftware

Python/Django-based software for running VAMDC data nodes.
http://www.vamdc.eu
GNU General Public License v3.0
15 stars 23 forks source link

Update ExampleNode to Django-3.1 and imptools to Python 3 #146

Closed guyrixon closed 1 year ago

guyrixon commented 1 year ago

ExampleNode can now be built with Django-3.1 like the operational nodes. I haven't tried to make it work with Django-4 yet.

The data files *.in committed with ExampleNode were corrupt, and rebuilding them required imptools to run. Therefore, imptools is minimally changed to run with Python 3.

transitions.dat committed in ExampleNode was incorrect: two columns were merged by missing commas. This is fixed.

ExampleNode is now configured to use SQLite instead of MySQL. The README has been changed to reflect this, and contains the commands for sqlite3 to load the data.

ivh commented 1 year ago

Hi Guy! Thanks for this! Is there a reason you have not merged this into master right away? Anything for me to look at before I press the "Squash & merge"-button? :)

guyrixon commented 1 year ago

Hi Thomas,

AFAIK it can go to master immediately, but I wanted you to see what I was about before merging. There might be subtleties I don’t know.

Imptools seems top be working with Python-3 now, but I didn’t manage to make files that could be ingested directly into sqlite. I used manual editing of the imptools output to make them ingestible, so the script in the README for ExampoleNode does not currently refer to imptools at all.

I have some more updates to make it easier to build container images. I’ll make a separate pull-request for those.

Cheers, Guy

On 3 Jan 2023, at 08:48, Thomas Marquart @.***> wrote:

Hi Guy! Thanks for this! Is there a reason you have not merged this into master right away? Anything for me to look at before I press the "Squash & merge"-button? :)

— Reply to this email directly, view it on GitHub https://github.com/VAMDC/NodeSoftware/pull/146#issuecomment-1369511554, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACGM7AJUJLKUCEIWN4243LWQPRW3ANCNFSM6AAAAAATMFH3N4. You are receiving this because you authored the thread.