VAMDC / NodeSoftware

Python/Django-based software for running VAMDC data nodes.
http://www.vamdc.eu
GNU General Public License v3.0
15 stars 23 forks source link

Accuracy in DataSeriesType optional, but required by Validator Tool #99

Closed johannespostler closed 12 years ago

johannespostler commented 12 years ago

The documentation says that accuracy elements for DataSeriesType are optional:

http://vamdc.eu/documents/standards/dataModel/vamdcxsams/types.html#dataseriestype

However, the validator complains if I don't set them. Setting them however, is not working, as the generator is ignoring the values for accuracy. My dictionary.py:

[...] 'CollisionTabulatedDataXAccuracyRelative':'false', [...]

This hard-coded value for example gets ignored. I tried putting the value in a way that the generator should loop over it, but that doesn't work either.

guyrixon commented 12 years ago

I presume that you have a dictionary entry for CollisionTabulatedDataXAccuracy to set the value of the accuracy. If so, writing the accuracy should just work, as you have it, so the generator needs attention. In the meantime, you could try putting a function that returns false in the RHS:

'CollisionTabulatedDataXAccuracyRelative':'false()',

In any case, @relative defaults to false, so you could just omit the attribute.

johannespostler commented 12 years ago

Well I'm not entirely sure which value to set. I would say either CollisionTabulatedDataXAccuracy or CollisionTabulatedDataXAccuracyErrorValue sound like they could be responsible for that. Anyway, neither of them works. My dictionary concerning errors looks like this:

'CollisionTabulatedDataXAccuracyType':'statistical', 'CollisionTabulatedDataXAccuracyRelative':'false', 'CollisionTabulatedDataXAccuracyErrorValue':'0.5', 'CollisionTabulatedDataXAccuracy':'0.5',

It doesn't make any difference if I set the AccuracyType or uncomment it.

ivh commented 12 years ago

This was an error in makeDataSeriesAccuracyType() that tried to look up the wrong keyword. It should be fixed now, both in master and release branch.