search

VAR-solutions / Algorithms

A repository of different Algorithms and Data Structures implemented in many programming languages.
https://var-solutions.github.io/Algorithms/
MIT License
758 stars 1.01k forks source link

add algorithms and data structures in any language #163

Open i-vishi opened 5 years ago

i-vishi commented 5 years ago

Dated: Oct-07-2020 Regarding Delay in reviewing PR Hello, everyone, I am one of the maintainer of this repository. I know most of the PRs are the part of hacktoberfest and most of you are worried will your PRs will be eligible for Hacktoberfest 2020 or not. Since, all the maintainers are busy, it will take some time to review all the PRs. We have to review each PR and it may take some time. Also, the rules of Hacktoberfest have been changed to reduce spam PRs. There are many SPAM PRs with invalid code or no code. So, we have to review each PR one by one. Due to the changes in rules, the burden has been shifted to maintainers.

About adding and then removing hacktoberfest-accepted label, it was just to check and verify the eligibility of the label. Do not consider it as making your PR invalid.

All the PRs will be checked and reviewed

Thanks and Happy coding :computer: :man_technologist: :woman_technologist: :computer:

i-vishi commented 5 years ago

Anyone can work on it. You only need to fork the repository and edit and then give a pull request. Just mention the issue in comment while giving Pull Request

ananthuc73 commented 5 years ago

Like to Add Bucket sorting algorithm in C++

Santan47 commented 5 years ago

added doubly LinkedList in c. #699

anmol20goyal commented 4 years ago

I can provide the algorithm for singly and double linked list in c++ language @i-vishi

ankur-kayal commented 3 years ago

Can i add Kahn's Algorithm for topological sort with proper documentation in this repo?

anmol20goyal commented 3 years ago

Yes

On Thu, Oct 1, 2020, 11:20 AM Ankur Kayal notifications@github.com wrote:

Can i add Kahn's Algorithm for topological sort with proper documentation in this repo?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/VAR-solutions/Algorithms/issues/163#issuecomment-701902546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKOOZTZORHTEN6JMOJ4SO5DSIQKCHANCNFSM4FZOHK6Q .

nilam23 commented 3 years ago

I would like to implement few standard problems of linked list. Can I go ahead?

ankur-kayal commented 3 years ago

Can you assign me this ?

i-vishi commented 3 years ago

@ankur-kayal just give a PR for whatever algorithm you want to add, we will check and merge it

i-vishi commented 3 years ago

@nilam23 Sure, go ahead and make sure you follow all the guidelines mentioned in README

ankur-kayal commented 3 years ago

@i-vishi documentation needed? or do i only implement the algorithm?

i-vishi commented 3 years ago

@ankur-kayal the code must be well-documented.

ankur-kayal commented 3 years ago

@i-vishi noted!

nilam23 commented 3 years ago

@i-vishi there has been some problems while cloning the repository. Please have a look at the screenshots below-

NewCapture Capture
sakshi006 commented 3 years ago

Can i add sieve of eratosthenes algorithm in c++?

i-vishi commented 3 years ago

@nilam23 update your fork and then try to clone the repository

i-vishi commented 3 years ago

@sakshi006 Sieve of eratosthenes is already implemented in C++, it is inside Mathematics directory.

ankur-kayal commented 3 years ago

@i-vishi i am facing the same issue as @nilam23 when i cloned the repo.

i-vishi commented 3 years ago

@ankur-kayal Can you provide the complete error message?

ankur-kayal commented 3 years ago

it is the same as @nilam23 provided. 

Cloning into 'Algorithms-1'...
remote: Enumerating objects: 40, done.
remote: Counting objects: 100% (40/40), done.
remote: Compressing objects: 100% (40/40), done.
Receiving objects: 100% (6970/6970), 3.41 MiB | 148.00 KiB/s, done. eceiving objects: 100% (6970/6970), 3.36 MiB | 122.00 KiB/s

Resolving deltas: 100% (2856/2856), done.
error: invalid path 'Divide and Conquer /closest_points.py'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
nilam23 commented 3 years ago

@ankur-kayal @i-vishi Yes. There has been a problem with the Path Name associated with the Divide and Conquer file. If you can, kindly remove the trailing whitespaces (both left and right) from this directory name.

i-vishi commented 3 years ago

@ankur-kayal @nilam23 are you both using Windows OS? It works on Linux. Anyways, I have changed the name. Thank you for pointing out

nilam23 commented 3 years ago

Yes, I am.

On Thu, 1 Oct 2020, 3:48 pm Vishal Gaur, notifications@github.com wrote:

@ankur-kayal https://github.com/ankur-kayal @nilam23 https://github.com/nilam23 are you both using Windows OS?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VAR-solutions/Algorithms/issues/163#issuecomment-702037631, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANVMQ3XPTDZ47ZXYMNNINMLSIRJPTANCNFSM4FZOHK6Q .

i-vishi commented 3 years ago

Do let me know if the problem persists

ankur-kayal commented 3 years ago

@i-vishi i am working on windows too

nilam23 commented 3 years ago

@i-vishi remove the right trailing whitespace, too. The problem still persists.

ankur-kayal commented 3 years ago

@i-vishi still the problem persists :(

Update: The issue has been resolved :) Thanks @i-vishi

ankur-kayal commented 3 years ago

@nilam23 delete the old fork, make a new fork and clone that. It will be resolved

nilam23 commented 3 years ago

@i-vishi @ankur-kayal Thanks both of you.

raj5036 commented 3 years ago

Adding Grid Unique paths (Possible number of ways to travel a grid from starting block to ending).Implementing in CPP and JAVA.

ankur-kayal commented 3 years ago

@i-vishi Pull request added #1217

saiharsha-22 commented 3 years ago

@i-vishi I have added a separate folder for Java programs TREE traversal and CPP folders and move codes to respective folders. I have sent a pull request, can you please check it once. Tree Traversal in Java Programming #1220

zahinekbal commented 3 years ago

@i-vishi I added Kadane's algorithm for maximum- subarray-sum in Array Folder with Explanation ,Algorithms ,Example & Implementation. i.e:- Arrays/Maximum_Subarray_Sum/KADANE'S_ALGORITHM/C++/Kadane's_algorithm.c++ kindly check my code & review my PR.....

zahinekbal commented 3 years ago

@i-vishi Can i add Graph's problem with description .implementation & example...?

sameersrivastava13 commented 3 years ago

@i-vishi i would like to add the partition problem (linked list)of leetcode in c language. Please give a 👍 so that i can give a PR for the same.

i-vishi commented 3 years ago

@zahinekbal Sure, go ahead and implement. :+1:

zahinekbal commented 3 years ago

@i-vishi I added Kadane's algorithm for maximum- subarray-sum in Array Folder with Explanation ,Algorithms ,Example & Implementation. i.e:- Arrays/Maximum_Subarray_Sum/KADANE'S_ALGORITHM/C++/Kadane's_algorithm.c++ kindly check my code & review my PR.....

ravichaudhary8434 commented 3 years ago

I've added KMP search algorithm #1302 @i-vishi @antew7 , kindly review

zahinekbal commented 3 years ago

@i-vishi I Added one of the important problem of Graph(Religious people) .In that I mentioned PROBLEM DESCRIPTION , 6 TEST CASES , CONSTRAINTS , SAMPLE INPUT & OUTPUT , EXPLANATION & HINT AND CODE.... please check the code... & review my PR....

zahinekbal commented 3 years ago

@i-vishi I updated my code Kadane's algorithm for maximum-subarray-sum..... i.e:- data structures/array/Maximum-Subarray-Sum/KADANE'S_ALGORITHM/C++/Kadane's_algorithm.c++

please check my code and review my PR

subhayuroy commented 3 years ago

I have added a new method for Linked List as well as a comparison between two methods for calculating fastest Prime number calculation.

zahinekbal commented 3 years ago

@i-vishi can I add C++ STL algorithms (i.e bubble sorting , Binary seacrh in STL)

pawan-git7979 commented 3 years ago

Hey bro, can i add the important ques of data structures including LL, Arrays, Strings , trees, stack, queue in c++ language, because i m seeing that algorithms that i know had been covered already. please assign me some task , so i can contribute and can create my first ever pull request. thanks in advance.

i-vishi commented 3 years ago

@pawan-git7979 we can not merge the pull request for the algorithms which have been already covered. If you find some error in the current implementation or want to add some explanation, then you can work on that algorithm.

i-vishi commented 3 years ago

@zahinekbal It is not required to add algorithms using STL. Any improvements in the current implementation can be appreciated.

zahinekbal commented 3 years ago

@zahinekbal It is not required to add algorithms using STL. Any improvements in the current implementation can be appreciated.

Okk @i-vishi kindly check my graph problem & kadane's algorithm that I hv added nd please review my PR.. Thankyou

ghost commented 3 years ago

1259 @i-vishi why u r not merging it after seeing it also if their is a need of improvement then tell me na

zahinekbal commented 3 years ago

1259 @i-vishi why u r not merging it after seeing it also if their is a need of improvement then tell me na

Exactly same for me..

zahinekbal commented 3 years ago

@zahinekbal It is not required to add algorithms using STL. Any improvements in the current implementation can be appreciated.

Okk @i-vishi kindly check my graph problem & kadane's algorithm that I hv added nd please review my PR.. Thankyou

Kindly check it @i-vishi I added graph problem & kadane's algorithm Check it nd review my PR .. If anything needed then please tell me.

zahinekbal commented 3 years ago

@zahinekbal Sure, go ahead and implement. 👍

@i-vishi kindly check my code and review my PR..